Enable matching temporal as from_type to Utf8View#6872
Merged
tustvold merged 2 commits intoapache:mainfrom Dec 12, 2024
Merged
Conversation
tustvold
approved these changes
Dec 12, 2024
This was referenced Mar 20, 2025
alamb
pushed a commit
to alamb/arrow-rs
that referenced
this pull request
Jan 8, 2025
* enable matching temporal from_type * drop todo message
alamb
added a commit
that referenced
this pull request
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6734
Rationale for this change
The original patterns do not contain that matches from
TimestamptoUtf8View, causing it throwsCastError("Casting from Timestamp(Millisecond, None) to Utf8View not supported")What changes are included in this PR?
Match
from_type.is_primitive()instead offrom_type.is_numeric(). Uncomment relevant tests.Are there any user-facing changes?
No.